[PATCH v0 2/7] ASoC: codecs: ES8389: Fix the issue about mclk_src
Michael Zhang <[email protected]> Mon, 8 Jun 2026 16:35:35 +0800
| Newsgroups | org.alsa-project.alsa-devel,org.kernel.vger.linux-devicetree |
|---|---|
| Message-ID | <[email protected]> |
From: Zhang Yi <[email protected]> Fix the issue with incorrect modifications to mclk_src Signed-off-by: Zhang Yi <[email protected]> --- sound/soc/codecs/es8389.c | 2 +- sound/soc/codecs/es8389.h | 7 ++++--- 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/sound/soc/codecs/es8389.c b/sound/soc/codecs/es8389.c index 9c816491648c..638eb1f0462e 100644 --- a/sound/soc/codecs/es8389.c +++ b/sound/soc/codecs/es8389.c @@ -609,7 +609,7 @@ static int es8389_pcm_hw_params(struct snd_pcm_substream *substream, if (es8389->mclk_src == ES8389_SCLK_PIN) { regmap_update_bits(es8389->regmap, ES8389_MASTER_CLK, - ES8389_MCLK_SOURCE, es8389->mclk_src); + ES8389_MCLK_MASK, es8389->mclk_src); es8389->sysclk = params_channels(params) * params_width(params) * params_rate(params); } diff --git a/sound/soc/codecs/es8389.h b/sound/soc/codecs/es8389.h index d21e72f876a6..13ce241774dc 100644 --- a/sound/soc/codecs/es8389.h +++ b/sound/soc/codecs/es8389.h @@ -116,9 +116,10 @@ #define ES8389_TDM_SLOT (0x70 << 0) #define ES8389_TDM_SHIFT 4 -#define ES8389_MCLK_SOURCE (1 << 6) -#define ES8389_MCLK_PIN (1 << 6) -#define ES8389_SCLK_PIN (0 << 6) +#define ES8389_MCLK_MASK (3 << 6) +#define ES8389_MCLK_SOURCE (0 << 6) +#define ES8389_MCLK_PIN (0 << 6) +#define ES8389_SCLK_PIN (1 << 6) /* ES8389_FMT */ #define ES8389_S24_LE (0 << 5) -- 2.54.0.windows.1