Re: [PATCH v0 0/7] ASoC: codecs: ES8389: Modify the ES8389 driver

On 6/8/2026 10:35 AM, Michael Zhang wrote:
> From: Zhang Yi <[email protected]>
> 
> v0:
>    - Modify volatile_register
>    - Add MCLK_MASK to resolve the issue related to mclk_src
>    - Modify configuration about clock
>    - Add private members about HPF at driver and devicetree
>    - Add INPUT MUX at route

Hi Michael,

The cover letter is supposed to provide a summary for the patchset and a 
goal behind it.  Bullet list that just repeats commits titles is _not_ a 
summary.  Next, there is no need to provide "changes made in v0" as 
there is no revision to match this one against - after all, it's the 
first revision.

For all the patches, except 1/7 - please update the commit message so 
that it answers _why_ the change it made.  Currently, you're just 
repeating the title.
Last but not least, the expected list is: [email protected], 
not [email protected].


> Zhang Yi (7):
>    ASoC: codecs: ES8389: Modify volatile_register
>    ASoC: codecs: ES8389: Fix the issue about mclk_src
>    ASoC: codecs: ES8389: Modify the clock table
>    ASoC: codecs: ES8389: Modify the initial configuration
>    ASoC: codecs: ES8389: Add private members related to HPF
>    ASoC: codecs: ES8389: Add INPUTL MUX and INPUTR MUX
>    ASoC: dt-bindings: ES8389: Add members about HPF
> 
>   .../bindings/sound/everest,es8389.yaml        |  18 +++
>   sound/soc/codecs/es8389.c                     | 130 +++++++++++++-----
>   sound/soc/codecs/es8389.h                     |   8 +-
>   3 files changed, 121 insertions(+), 35 deletions(-)
>