Re: [PATCH 7/7] ASoC: dt-bindings: ES8389: Add members about HPF and clock

> Please organize the patch documenting the ABI (DT bindings)

> before the patch using that ABI.

> See also:
https://elixir.bootlin.com/linux/v6.14-rc6/source/Documentation/devicetree/b
indings/submitting-patches.rst#L46

 

Thanks for the reminder

 

> > +  everest,mclk-from-sclk:

> > +    $ref: /schemas/types.yaml#/definitions/flag

> > +    description:

> > +      Indicates that SCLK is used as the internal clock.

> 

> And what happens with mclk in such case? Is it still wired?

 

Yes, setting mclk-from-sclk does not affect the MCLK connection.

 

> > +

> > +  everest,hpfl:

> > +    $ref: /schemas/types.yaml#/definitions/uint8

> > +    description:

> > +      the HPF value of ADCL.

> 

> Is HPF value in dB? If so, use proper unit suffix and proper units.

 

No, the values here correspond to the values in the registers.

The value is not in dB

 

> >          vddd-supply = <&vdd3v3>;

> >          vdda-supply = <&vdd3v3>;

> > +        everest,hpfl = [0a];

> 

> <0xa>? What did you want to say here?

 

I just wanted to give an example to show how to set the values of
everest,hpfl to 0x0a.