Re: [PATCH v1] ASoC: Intel: soc-acpi-ptl-match: add tas2783 support

Andy Shevchenko <[email protected]> Mon, 29 Jun 2026 09:15:10 +0300
Newsgroups org.alsa-project.alsa-devel,org.kernel.vger.linux-kernel,org.kernel.vger.linux-sound
Organization Intel Finland Oy - BIC 0357606-4 - c/o Alberga Business Park, 6 krs, Bertel Jungin Aukio 5, 02600 Espoo
Message-ID <[email protected]>
On Sun, Jun 28, 2026 at 08:25:43PM +0800, Baojun Xu wrote:
> Added tas2783 support in some projects.

...

> +static const struct snd_soc_acpi_adr_device tas2783_0_adr[] = {
> +	{
> +		.adr = 0x0000300102278301ull,
> +		.num_endpoints = ARRAY_SIZE(tas2783_endpoints),
> +		.endpoints = tas2783_endpoints,
> +		.name_prefix = "tas2783"

Leave trailing comma for the non-terminator entries.

> +	}
> +};

...

> +static const struct snd_soc_acpi_adr_device tas2783_2_adr[] = {
> +	{
> +		/* left */
> +		.adr = 0x0000390102000001ull,
> +		.num_endpoints = 1,
> +		.endpoints = &spk_r_endpoint,
> +		.name_prefix = "tas2783-1"

Ditto.

> +	},
> +	{
> +		/* right */
> +		.adr = 0x00003c0102000001ull,
> +		.num_endpoints = 1,
> +		.endpoints = &spk_r_endpoint,
> +		.name_prefix = "tas2783-2"

Ditto.

> +	},
> +};

...

...and so on for Intel case.

-- 
With Best Regards,
Andy Shevchenko