Re: [PATCH 16/16] ASoC: SOF: amd: add system and runtime PM ops for ACP7x
"Mukunda,Vijendar" <[email protected]> Fri, 3 Jul 2026 22:21:25 +0530
| Newsgroups | org.alsa-project.alsa-devel,org.kernel.vger.linux-kernel,org.kernel.vger.linux-sound |
|---|---|
| Message-ID | <[email protected]> |
On 7/3/26 21:58, Mark Brown wrote: > On Wed, Jul 01, 2026 at 03:25:17PM +0530, Vijendar Mukunda wrote: >> Add amd_sof_acp7x_suspend() and amd_sof_acp7x_resume() for ACP7.B/7.F >> platforms power management. > The interrupt is requested with IRQF_SHARED so probably worth double > checking if the interrupt handler is safe to run while the suspend and > resume callbacks are running, I see we reset the device during suspend > so there might be some risk of corrupted register reads? There won't be any corrupted register reads when acp reset sequence is executed, all the acp registers are set to default values. i.e Interrupt control registers are disabled. This sequence ensures that till interrupt masks are enabled during resume sequence, no interrupt will be asserted for ACP IP.