Re: [PATCH v6 2/2] ASoC: codecs: nau8360: Add support for NAU83G60 amplifier

--bPb+sFRLKRrMY7hN
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Wed, Jul 08, 2026 at 05:35:06PM +0800, Neo Chang wrote:
> Add support for the Nuvoton NAU83G60 audio codec. The NAU83G60 is a
> stereo 30W+30W smart amplifier with an integrated low-latency
> Advanced Audio DSP.

> +static int nau8360_dsp_chan_kcs_setup(struct snd_soc_component *cp,
> +       const char *fw_name, int dsp_addr)

> +       ret = request_firmware_nowait(THIS_MODULE, true,
> +               fw_name, dev, GFP_KERNEL, ctx, nau8360_dsp_fw_cb);

This gets run every resume but there's no cleanup so if for some reason
we get suspend/resumes running back to back and the firmware load
doesn't complete, or the driver gets removed while the firmware loads
are pending during normal probe, nothing cancels the firmware loads and
they might end up completing.  Both suspend and remove should clean up
anything that's pending.

There's a bunch of issues reported by Sashiko:

   https://sashiko.dev/#/patchset/20260708093506.895481-1-YLCHANG2%40nuvoton.com

some of which looked valid.

--bPb+sFRLKRrMY7hN
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmpOoPoACgkQJNaLcl1U
h9ApFgf/XITbLpbuaEsOktfRrg4vKBaYvkVaUPW5mhT7anTKrSX69Ce+SEnRWo8V
cmTotB0Z8zn8ziV3QYo+zt+q/ecmEkEHCSWVmdUPNDhdRwriNMB7u1JZ1R9Wo/ho
BIIARxALZI4I06wE0gJii1sY9oh9kIFJOHzcIWDjEHdDQXXdZI6JLTivh4etD4Ac
9sK4KQ3XKuphSCu07zP1Y/+lcGjss7+N5VyY2OpSKZ1oVKLzqXsLsJI7pYUw1L90
+kZRHM5Ea1CzQ2cnY17SYQeDmKz2aNVLs3F+dzjBceIPshYqI2FW4fPlcZPFPU20
mtZD0lC4x+xcMc/1ePCj0er3ucfZCA==
=wcRd
-----END PGP SIGNATURE-----

--bPb+sFRLKRrMY7hN--