Re: [REGRESSION 7.2-rc3] ASoC: cs35l56: compo nent probe waits for an init_completion that cannot be signalle d until the wait ends — whole sof_sdw card fails
Richard Fitzgerald <[email protected]> Thu, 16 Jul 2026 12:32:26 +0100
| Newsgroups | org.alsa-project.alsa-devel,org.kernel.vger.linux-sound |
|---|---|
| Message-ID | <[email protected]> |
This is a multi-part message in MIME format. --------------uiWAg02dM007x2p93ekG57xq Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 16/07/2026 9:06 am, Salman S. Tahir wrote: > Hi Richard, > > Thanks for the diagnosis and the complete() -> complete_all() suggestion. I > tested it before replying, and I'm sorry to report it does not fix the > failure > on this machine (Lenovo Yoga 9i 14ILL10, two SPI CS35L56 B0 amps, 7.2-rc3). Can you try the attached patch? --------------uiWAg02dM007x2p93ekG57xq Content-Type: text/x-patch; charset=UTF-8; name="0001-ASoC-cs35l56-Fix-possible-probe-deadlock.patch" Content-Disposition: attachment; filename="0001-ASoC-cs35l56-Fix-possible-probe-deadlock.patch" Content-Transfer-Encoding: base64 RnJvbSAxYzVkYWExNjQ1ZmNiMzM0YWJiNDVjNmZjMzgzYzUyYzE5MTk0NmE2IE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBSaWNoYXJkIEZpdHpnZXJhbGQgPHJmQG9wZW5zb3Vy Y2UuY2lycnVzLmNvbT4KRGF0ZTogVGh1LCAxNiBKdWwgMjAyNiAxMTowMjowNiArMDEwMApT dWJqZWN0OiBbUEFUQ0hdIEFTb0M6IGNzMzVsNTY6IEZpeCBwb3NzaWJsZSBwcm9iZSgpIGRl YWRsb2NrCgpPbiBJMkMvU1BJIGNhbGwgY3MzNWw1Nl9pbml0KCkgYmVmb3JlIGNhbGxpbmcK c25kX3NvY19yZWdpc3Rlcl9jb21wb25lbnQoKSB0byBwcmV2ZW50IHRoZSBwb3RlbnRpYWwg Zm9yIGEgZGVhZGxvY2sKb24gaW5pdF9jb21wbGV0aW9uLgoKRm9yIG1vc3QgYnVzZXMgYWxs IHRoZSBoYXJkd2FyZSB3b3VsZCBiZSByZWFkeSB3aGVuIHByb2JlKCkgcmV0dXJucywKYnV0 IG9uIFNvdW5kV2lyZSwgcHJvYmUoKSBtdXN0IHJldHVybiBiZWZvcmUgdGhlIFNvdW5kV2ly ZSBidXMgZHJpdmVyCndpbGwgZW51bWVyYXRlIHRoZSBkZXZpY2UuIEFsbCBhY2Nlc3MgdG8g dGhlIHJlZ2lzdGVycyBtdXN0IGJlIGRlZmVycmVkCnVudGlsIHRoZSBkcml2ZXIgcmVjZWl2 ZXMgYW4gQVRUQUNIRUQgbm90aWZpY2F0aW9uLiBCdXQgYW55dGhpbmcgdGhhdApjb3VsZCBy ZXR1cm4gLUVQUk9CRV9ERUZFUiBtdXN0IGJlIGNhbGxlZCBkdXJpbmcgcHJvYmUsIGFuZCB0 aGF0IGluY2x1ZGVzCnNuZF9zb2NfcmVnaXN0ZXJfY29tcG9uZW50KCkuIEJlY2F1c2Ugb2Yg dGhhdCwgb24gU291bmRXaXJlIHRoZSBBU29DCmNvbXBvbmVudCBjYW4gYmUgY3JlYXRlZCBi ZWZvcmUgdGhlIHJlZ2lzdGVycyBhcmUgYWNjc3NpYmxlLCBzbwpjczM1bDU2X2NvbXBvbmVu dF9wcm9iZSgpIHdhaXRzIGZvciBpbml0X2NvbXBsZXRpb24gdG8gc2lnbmFsIHRoYXQgdGhl CnJlZ2lzdGVycyBhcmUgYWNjZXNzaWJsZS4KCk9uIEkyQy9TUEkgdGhpcyAyLXN0YWdlIHN0 YXJ0dXAgaXNuJ3QgcmVxdWlyZWQgc28gdGhlaXIgcHJvYmUoKQpmdW5jdGlvbnMgc2ltcGx5 IGNhbGxlZCBjczM1bDU2X2NvbW1vbl9wcm9iZSgpIGFuZCB0aGVuIGNzMzVsNTZfaW5pdCgp LgpUaGUgcHJvYmxlbSB3aXRoIHRoaXMgd2FzIHRoYXQgc25kX3NvY19yZWdpc3Rlcl9jb21w b25lbnQoKSB3YXMgc3RpbGwKY2FsbGVkIGVhcmx5LiBJZiB0aGlzIHRyaWdnZXJlZCBBU29D IHRvIGNyZWF0ZSB0aGUgY2FyZCwgQVNvQyB3b3VsZCBjYWxsCmNzMzVsNTZfY29tcG9uZW50 X3Byb2JlKCkgd2hpY2ggd2FpdHMgb24gaW5pdF9jb21wbGV0aW9uIC0gYnV0IHRoaXMgd291 bGQKYmUgcnVubmluZyBpbnNpZGUgdGhlIGNzMzVsNTYgZHJpdmVyIHByb2JlKCkgc28gYmxv Y2tpbmcgaXQgZnJvbSByZWFjaGluZwp0aGUgY29kZSB0aGF0IHNpZ25hbHMgaW5pdF9jb21w bGV0aW9uLCBjYXVzaW5nIGEgZGVhZGxvY2suCgpGaXhlczogZTQ5NjExMjUyOTAwNiAoIkFT b0M6IGNzMzVsNTY6IEFkZCBkcml2ZXIgZm9yIENpcnJ1cyBMb2dpYyBDUzM1TDU2IikKUmVw b3J0ZWQtYnk6IFNhbG1hbiBTLiBUYWhpciA8c2FsbWFuLmFidXNhYWRAZ21haWwuY29tPgpD bG9zZXM6IGh0dHBzOi8vbG9yZS5rZXJuZWwub3JnL2xpbnV4LXNvdW5kLzk1YzIxNTc0LTk3 ZDUtNDMxMS05MjYzLTllMTc0ZDIyZDIyY0BvcGVuc291cmNlLmNpcnJ1cy5jb20vVC8jdQpT aWduZWQtb2ZmLWJ5OiBSaWNoYXJkIEZpdHpnZXJhbGQgPHJmQG9wZW5zb3VyY2UuY2lycnVz LmNvbT4KLS0tCiBzb3VuZC9zb2MvY29kZWNzL2NzMzVsNTYtaTJjLmMgfCAgNCArLS0tCiBz b3VuZC9zb2MvY29kZWNzL2NzMzVsNTYtc3BpLmMgfCAgNCArLS0tCiBzb3VuZC9zb2MvY29k ZWNzL2NzMzVsNTYuYyAgICAgfCAxNSArKysrKysrKysrKysrKysKIDMgZmlsZXMgY2hhbmdl ZCwgMTcgaW5zZXJ0aW9ucygrKSwgNiBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9zb3Vu ZC9zb2MvY29kZWNzL2NzMzVsNTYtaTJjLmMgYi9zb3VuZC9zb2MvY29kZWNzL2NzMzVsNTYt aTJjLmMKaW5kZXggMGY2NGFiNjI4YjAzYi4uNGY2ZGRmMWM1YTNmNiAxMDA2NDQKLS0tIGEv c291bmQvc29jL2NvZGVjcy9jczM1bDU2LWkyYy5jCisrKyBiL3NvdW5kL3NvYy9jb2RlY3Mv Y3MzNWw1Ni1pMmMuYwpAQCAtNTUsOSArNTUsNyBAQCBzdGF0aWMgaW50IGNzMzVsNTZfaTJj X3Byb2JlKHN0cnVjdCBpMmNfY2xpZW50ICpjbGllbnQpCiAJaWYgKHJldCAhPSAwKQogCQly ZXR1cm4gcmV0OwogCi0JcmV0ID0gY3MzNWw1Nl9pbml0KGNzMzVsNTYpOwotCWlmIChyZXQg PT0gMCkKLQkJcmV0ID0gY3MzNWw1Nl9pcnFfcmVxdWVzdCgmY3MzNWw1Ni0+YmFzZSwgY2xp ZW50LT5pcnEpOworCXJldCA9IGNzMzVsNTZfaXJxX3JlcXVlc3QoJmNzMzVsNTYtPmJhc2Us IGNsaWVudC0+aXJxKTsKIAlpZiAocmV0IDwgMCkKIAkJY3MzNWw1Nl9yZW1vdmUoY3MzNWw1 Nik7CiAKZGlmZiAtLWdpdCBhL3NvdW5kL3NvYy9jb2RlY3MvY3MzNWw1Ni1zcGkuYyBiL3Nv dW5kL3NvYy9jb2RlY3MvY3MzNWw1Ni1zcGkuYwppbmRleCA5YmM5YjdjOTgzOTBkLi5iMWVi OTI0YTViNmNjIDEwMDY0NAotLS0gYS9zb3VuZC9zb2MvY29kZWNzL2NzMzVsNTYtc3BpLmMK KysrIGIvc291bmQvc29jL2NvZGVjcy9jczM1bDU2LXNwaS5jCkBAIC00NCw5ICs0NCw3IEBA IHN0YXRpYyBpbnQgY3MzNWw1Nl9zcGlfcHJvYmUoc3RydWN0IHNwaV9kZXZpY2UgKnNwaSkK IAlpZiAocmV0ICE9IDApCiAJCXJldHVybiByZXQ7CiAKLQlyZXQgPSBjczM1bDU2X2luaXQo Y3MzNWw1Nik7Ci0JaWYgKHJldCA9PSAwKQotCQlyZXQgPSBjczM1bDU2X2lycV9yZXF1ZXN0 KCZjczM1bDU2LT5iYXNlLCBzcGktPmlycSk7CisJcmV0ID0gY3MzNWw1Nl9pcnFfcmVxdWVz dCgmY3MzNWw1Ni0+YmFzZSwgc3BpLT5pcnEpOwogCWlmIChyZXQgPCAwKQogCQljczM1bDU2 X3JlbW92ZShjczM1bDU2KTsKIApkaWZmIC0tZ2l0IGEvc291bmQvc29jL2NvZGVjcy9jczM1 bDU2LmMgYi9zb3VuZC9zb2MvY29kZWNzL2NzMzVsNTYuYwppbmRleCBmNDZmZDhlN2JjMDM5 Li4wYjdiMDgwOTM5YTE4IDEwMDY0NAotLS0gYS9zb3VuZC9zb2MvY29kZWNzL2NzMzVsNTYu YworKysgYi9zb3VuZC9zb2MvY29kZWNzL2NzMzVsNTYuYwpAQCAtMjAwOSw2ICsyMDA5LDE2 IEBAIGludCBjczM1bDU2X2NvbW1vbl9wcm9iZShzdHJ1Y3QgY3MzNWw1Nl9wcml2YXRlICpj czM1bDU2KQogCQlnb3RvIGVycjsKIAl9CiAKKwkvKgorCSAqIE9uIFNvdW5kV2lyZSB0aGUg Y3MzNWw1Nl9pbml0KCkgY2Fubm90IGJlIHJ1biB1bnRpbCBhZnRlciB0aGUKKwkgKiBkZXZp Y2UgaGFzIGJlZW4gZW51bWVyYXRlZCBieSB0aGUgU291bmRXaXJlIGNvcmUuCisJICovCisJ aWYgKCFjczM1bDU2LT5zZHdfcGVyaXBoZXJhbCkgeworCQlyZXQgPSBjczM1bDU2X2luaXQo Y3MzNWw1Nik7CisJCWlmIChyZXQpCisJCQlnb3RvIGVycl9yZW1vdmVfd21fYWRzcDsKKwl9 CisKIAlyZXQgPSBzbmRfc29jX3JlZ2lzdGVyX2NvbXBvbmVudChjczM1bDU2LT5iYXNlLmRl diwKIAkJCQkJICZzb2NfY29tcG9uZW50X2Rldl9jczM1bDU2LAogCQkJCQkgY3MzNWw1Nl9k YWksIEFSUkFZX1NJWkUoY3MzNWw1Nl9kYWkpKTsKQEAgLTIwMjMsNiArMjAzMywxMSBAQCBp bnQgY3MzNWw1Nl9jb21tb25fcHJvYmUoc3RydWN0IGNzMzVsNTZfcHJpdmF0ZSAqY3MzNWw1 NikKIAl3bV9hZHNwMl9yZW1vdmUoJmNzMzVsNTYtPmRzcCk7CiAKIGVycjoKKwlpZiAocG1f cnVudGltZV9lbmFibGVkKGNzMzVsNTYtPmJhc2UuZGV2KSkgeworCQlwbV9ydW50aW1lX2Rv bnRfdXNlX2F1dG9zdXNwZW5kKGNzMzVsNTYtPmJhc2UuZGV2KTsKKwkJcG1fcnVudGltZV9k aXNhYmxlKGNzMzVsNTYtPmJhc2UuZGV2KTsKKwl9CisKIAlncGlvZF9zZXRfdmFsdWVfY2Fu c2xlZXAoY3MzNWw1Ni0+YmFzZS5yZXNldF9ncGlvLCAwKTsKIAlyZWd1bGF0b3JfYnVsa19k aXNhYmxlKEFSUkFZX1NJWkUoY3MzNWw1Ni0+c3VwcGxpZXMpLCBjczM1bDU2LT5zdXBwbGll cyk7CiAKLS0gCjIuNDcuMwoK --------------uiWAg02dM007x2p93ekG57xq--