Re: [PATCH v1] ASoC: tas2781: Add calibration kcontrols for TAS2573

Andy Shevchenko <[email protected]> Fri, 17 Jul 2026 14:02:08 +0300

Newsgroups	org.alsa-project.alsa-devel
Organization	Intel Finland Oy - BIC 0357606-4 - c/o Alberga Business Park, 6 krs, Bertel Jungin Aukio 5, 02600 Espoo
Message-ID	<[email protected]>

On Fri, Jul 17, 2026 at 03:39:27PM +0800, Shenghao Ding wrote:
> Add calibration kcontrols for TAS2573 in TAS2781 driver to support
> device-specific calibration settings.

...

>  		memcpy(config->name, &data[offset], 64);
> +		/* If in the coef bin file are several configs with the
> +		 * keyword "calib", init_profile_id only store the last
> +		 * init profile id, and same as calibration_profile_id.
> +		 */

/*
 * Even in this patch you have inconsistent style, try to follow
 * the correct one (as in this example) everywhere in the ASoC subsystem.
 * The above style is only approved in net subsystem.
 */

-- 
With Best Regards,
Andy Shevchenko