Re: [PATCH 3/3] ASoC: amd: ps: replace bitwise OR with logical OR in IRQ return check

On 7/7/26 00:59, Vijendar Mukunda wrote:
> The condition 'irq_flag | wake_irq_flag' uses bitwise OR to combine two
> integer flags that are used as booleans. Replace with logical OR '||' to
> correctly express the intended boolean check.
> 
> Signed-off-by: Vijendar Mukunda <[email protected]>
Fixes: 7f91f012c1df0 ("ASoC: amd: ps: fix for irq handler return status")
> ---
>   sound/soc/amd/ps/pci-ps.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/sound/soc/amd/ps/pci-ps.c b/sound/soc/amd/ps/pci-ps.c
> index 1162d13d8505..729f9aaba69e 100644
> --- a/sound/soc/amd/ps/pci-ps.c
> +++ b/sound/soc/amd/ps/pci-ps.c
> @@ -248,7 +248,7 @@ static irqreturn_t acp63_irq_handler(int irq, void *dev_id)
>   	if (sdw_dma_irq_flag)
>   		return IRQ_WAKE_THREAD;
>   
> -	if (irq_flag | wake_irq_flag)
> +	if (irq_flag || wake_irq_flag)
>   		return IRQ_HANDLED;
>   	else
>   		return IRQ_NONE;