Re: [PATCH v6 2/2] ASoC: codecs: nau8360: Add support for NAU83G60 amplifier

On 7/9/26 03:11, Mark Brown wrote:
> On Wed, Jul 08, 2026 at 05:35:06PM +0800, Neo Chang wrote:
>> Add support for the Nuvoton NAU83G60 audio codec. The NAU83G60 is a
>> stereo 30W+30W smart amplifier with an integrated low-latency
>> Advanced Audio DSP.
>> +static int nau8360_dsp_chan_kcs_setup(struct snd_soc_component *cp,
>> +       const char *fw_name, int dsp_addr)
>> +       ret = request_firmware_nowait(THIS_MODULE, true,
>> +               fw_name, dev, GFP_KERNEL, ctx, nau8360_dsp_fw_cb);
> This gets run every resume but there's no cleanup so if for some reason
> we get suspend/resumes running back to back and the firmware load
> doesn't complete, or the driver gets removed while the firmware loads
> are pending during normal probe, nothing cancels the firmware loads and
> they might end up completing.  Both suspend and remove should clean up
> anything that's pending.
Got it. We will add a completion mechanism in v7 to ensure the firmware 
load finishes.
>
> There's a bunch of issues reported by Sashiko:
>
>     https://sashiko.dev/#/patchset/20260708093506.895481-1-YLCHANG2%40nuvoton.com
>
> some of which looked valid.
We will review the report from Sashiko and fix the issues in v7 as well.