[ath9k-devel] [PATCH v4 3/3] ath9k: parse the device configuration from an OF node
Oleksij Rempel <[email protected]>
| Newsgroups | org.ath9k.lists.ath9k-devel,org.kernel.vger.linux-devicetree,org.kernel.vger.linux-wireless |
|---|---|
| Message-ID | <[email protected]> |
Am 10.07.2016 um 02:19 schrieb Bj?rn Mork: > Martin Blumenstingl <[email protected]> writes: > >> + if (of_property_read_bool(np, "qca,clk-25mhz")) >> + ah->is_clk_25mhz = true; >> + >> + if (of_property_read_bool(np, "qca,disable-2ghz")) >> + ah->disable_2ghz = true; >> + >> + if (of_property_read_bool(np, "qca,disable-5ghz")) >> + ah->disable_5ghz = true; > > This is bike-shedding, but how about > > ah->is_clk_25mhz = of_property_read_bool(np, "qca,clk-25mhz"); > ah->disable_2ghz = of_property_read_bool(np, "qca,disable-2ghz"); > ah->disable_5ghz = of_property_read_bool(np, "qca,disable-5ghz"); > > instead? Hm... i assume each WiFi hw in the world can reuse this settings, may be it i worth to use generic names? -- Regards, Oleksij -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 213 bytes Desc: OpenPGP digital signature Url : http://lists.ath9k.org/pipermail/ath9k-devel/attachments/20160710/c6337c74/attachment.pgp