[ath9k-devel] [PATCH v4 3/3] ath9k: parse the device configuration from an OF node
Martin Blumenstingl <[email protected]>
| Newsgroups | org.ath9k.lists.ath9k-devel,org.kernel.vger.linux-devicetree,org.kernel.vger.linux-wireless |
|---|---|
| Message-ID | <CAFBinCD0b9=o0B4_Orwe6uJfrbexr_Jf5JDctfRDmTnh3vPPug@mail.gmail.com> |
On Sun, Jul 10, 2016 at 2:19 AM, Bj?rn Mork <[email protected]> wrote: > Martin Blumenstingl <[email protected]> writes: > >> + if (of_property_read_bool(np, "qca,clk-25mhz")) >> + ah->is_clk_25mhz = true; >> + >> + if (of_property_read_bool(np, "qca,disable-2ghz")) >> + ah->disable_2ghz = true; >> + >> + if (of_property_read_bool(np, "qca,disable-5ghz")) >> + ah->disable_5ghz = true; > > This is bike-shedding, but how about > > ah->is_clk_25mhz = of_property_read_bool(np, "qca,clk-25mhz"); > ah->disable_2ghz = of_property_read_bool(np, "qca,disable-2ghz"); > ah->disable_5ghz = of_property_read_bool(np, "qca,disable-5ghz"); I'm fine with either way - I'll simply adhere to the coding style that the ath9k devs want to use, so just let me know which one you prefer.