[ath9k-devel] [PATCH v4 3/3] ath9k: parse the device configuration from an OF node

Bjørn Mork <[email protected]> Sun, 10 Jul 2016 00:32:42 -0000

Newsgroups	org.ath9k.lists.ath9k-devel,org.kernel.vger.linux-devicetree,org.kernel.vger.linux-wireless
Message-ID	<[email protected]>

Martin Blumenstingl <[email protected]> writes:

> +	if (of_property_read_bool(np, "qca,clk-25mhz"))
> +		ah->is_clk_25mhz = true;
> +
> +	if (of_property_read_bool(np, "qca,disable-2ghz"))
> +		ah->disable_2ghz = true;
> +
> +	if (of_property_read_bool(np, "qca,disable-5ghz"))
> +		ah->disable_5ghz = true;

This is bike-shedding, but how about

	ah->is_clk_25mhz = of_property_read_bool(np, "qca,clk-25mhz");
	ah->disable_2ghz = of_property_read_bool(np, "qca,disable-2ghz");
	ah->disable_5ghz = of_property_read_bool(np, "qca,disable-5ghz");

instead?


Bj?rn