[ath9k-devel] [PATCH] fix:gpio: mark symbols static where possible
Kalle Valo <[email protected]> Mon, 29 Aug 2016 15:14:05 +0300
| Newsgroups | org.ath9k.lists.ath9k-devel,org.kernel.vger.linux-kernel,org.kernel.vger.linux-wireless,org.kernel.vger.netdev |
|---|---|
| Message-ID | <[email protected]> |
Baoyou Xie <[email protected]> writes: > We get 1 warning about global functions without a declaration > in the ath9k gpio driver when building with W=1: > drivers/net/wireless/ath/ath9k/gpio.c:25:6: warning: no previous prototype for 'ath_fill_led_pin' [-Wmissing-prototypes] > > In fact, this function is only used in the file in which it is declared > and don't need a declaration, but can be made static. > so this patch marks it 'static'. > > Signed-off-by: Baoyou Xie <[email protected]> > --- > drivers/net/wireless/ath/ath9k/gpio.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) The commit title should be: ath9k: mark ath_fill_led_pin() static Check the wiki how to create titles: https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches#subject_name -- Kalle Valo