[ath9k-devel] [NOT FOR MERGE] ath9k: work around key cache corruption
Johannes Berg <[email protected]> Sat, 22 Oct 2016 22:34:16 +0200
| Newsgroups | org.ath9k.lists.ath9k-devel,org.kernel.vger.linux-wireless |
|---|---|
| Message-ID | <[email protected]> |
> "The patch itself has (at least) one big problem. It is using some > mac80211 > internals in ath_key_config_iter to make sure that the uploaded keys > were > actually programmed in the hardware. Without this check the keys > could end up > in the lower slots and thus break all connections." The?KEY_FLAG_UPLOADED_TO_HARDWARE use? Might not be so nice, but it's probably not really a problem. If you wanted to avoid it, you could just use the hw_key_idx in some way, e.g. the highest-order bit indicates that you've set this value, or you just make sure that 0 is an invalid value and set it to real index + 1 or something, then you can check that? johannes