Re: [PATCH 6.1.y-cip 14/23] hwmon: (lm75) Fix tmp112 default config
Pavel Machek <[email protected]> Mon, 20 Jul 2026 22:14:57 +0200
| Newsgroups | org.cip-project.lists.cip-dev |
|---|---|
| Message-ID | <[email protected]> |
Hi! > From: Abdel Alkuor <[email protected]> > > commit 8249a0e25dd2972e919a2552425bf4faa2581d24 upstream. > > Set tmp112 conversion rate to 8 HZ and 12-bit mode. > > Fixes: 35cd18048542 ("hwmon: (lm75) Aproximate sample times to data-sheet values") > Signed-off-by: Abdel Alkuor <[email protected]> > Link: https://lore.kernel.org/r/[email protected] > Signed-off-by: Guenter Roeck <[email protected]> > Signed-off-by: Tommaso Merciai <[email protected]> > --- > drivers/hwmon/lm75.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/drivers/hwmon/lm75.c b/drivers/hwmon/lm75.c > index f6e16dfa11c5..5eba180b66a0 100644 > --- a/drivers/hwmon/lm75.c > +++ b/drivers/hwmon/lm75.c > @@ -270,8 +270,9 @@ static const struct lm75_params device_params[] = { > .resolutions = (u8 []) {9, 10, 11, 12 }, > }, > [tmp112] = { > - .set_mask = 3 << 5, /* 8 samples / second */ > - .clr_mask = 1 << 7, /* no one-shot mode*/ > + .config_reg_16bits = true, > + .set_mask = 0x60C0, /* 12-bit mode, 8 samples / second */ > + .clr_mask = 1 << 15, /* no one-shot mode*/ I would not mind space before "*/". But not your code and not your patch... Best regards, Pavel
signature.asc
(application/pgp-signature, 195 B)
-----BEGIN PGP SIGNATURE----- iF0EABECAB0WIQRPfPO7r0eAhk010v0w5/Bqldv68gUCal6BwQAKCRAw5/Bqldv6 8lu+AJ94uKOYtv1K90ETGFOkUJB2teA8BwCfT3oejY6XDBw9GFi3MyYPNIjHXOw= =yIkS -----END PGP SIGNATURE-----