Re: [PATCH v1 1/2] net/dpaa2: revert inner RSS level support
Hemant Agrawal <[email protected]>
| Newsgroups | org.dpdk.dev |
|---|---|
| Message-ID | <[email protected]> |
Acked-by: Hemant Agrawal <[email protected]> On 21-07-2026 15:26, Thomas Monjalon wrote: > I'm waiting for an urgent reply from the maintainers here. > > > 20/07/2026 15:34, Maxime Leroy: >> This reverts commit 618a06c53d479ae576ff01c7d274b10c60b3d3d5. >> >> RTE_ETH_RSS_LEVEL_INNERMOST was mapped to the innermost IP instance by >> programming the IP key extracts with hdr_index = HDR_INDEX_LAST. The >> hardware only resolves that index when several IP headers are stacked. >> A non-tunnelled frame carries a single IP header, so the extract >> resolves to nothing, the RSS hash is constant and every such frame is >> steered to a single Rx queue. >> >> The ethdev API defines INNERMOST by encapsulation level, not by the >> presence of a tunnel: a plain frame's innermost header is its only IP >> header and must be hashed. The dpaa2 hardware cannot honour that and >> keep true inner-only semantics for tunnelled traffic at the same time, >> so the level cannot be implemented correctly as merged. >> >> Revert it. Hashing the outer plus the inner IP under the PMD default >> level, which spreads both plain and tunnelled traffic, is added in a >> follow-up. >> >> Signed-off-by: Maxime Leroy <[email protected]> > > >