Re: [PATCH] net/iavf: fix VLAN offload when inner VLAN is not supported

On Fri, Jul 17, 2026 at 04:33:37AM +0100, Mandal, Anurag wrote:
> > -----Original Message-----
> > From: Mandal, Anurag <[email protected]>
> > Sent: 16 July 2026 04:23
> > To: [email protected]
> > Cc: Richardson, Bruce <[email protected]>; Medvedkin, Vladimir
> > <[email protected]>; Mandal, Anurag
> > <[email protected]>; [email protected]
> > Subject: [PATCH] net/iavf: fix VLAN offload when inner VLAN is not supported
> > 
> > In Double VLAN mode (DVM) i.e. when RTE_ETH_RX_OFFLOAD_VLAN_EXTEND
> > is enabled, the single VLAN offloads are programmed on the inner VLAN
> > (0x8100) engine by iavf_config_vlan_strip_v2() & iavf_config_vlan_insert_v2().
> > When the PF/hardware does not advertise inner VLAN offloading capabilities,
> > these functions return -ENOTSUP.
> > 
> > On the enable path,these -ENOTSUP are trsnalated into -EIO, which makes
> > device configuration fail.
> > However, in DVM, with the default outer TPID set as 0x8100, a single 0x8100
> > tagged VLAN frame is handled by the outer VLAN engine, so the missing inner
> > capability is harmless and should not fail the configuration.
> > 
> > This patch fixes the same by returning success when DVM is enabled and the
> > outer TPID is 0x8100, so the outer VLAN engine services the single VLAN.
> > Changed "qinq" flag from 'int' to 'bool' to address memory wastage.
> > 
> > Fixes: 8599d7604e0a ("net/iavf: support QinQ strip")
> > Cc: [email protected]
> > 
> > Signed-off-by: Anurag Mandal <[email protected]>
> Tested-by: Daxue Gao <[email protected]>
> 
Applied to dpdk-next-net-intel.
Thanks,
/Bruce