RE: [PATCH v2 5/7] net/iavf: improve VF reset detection on fast ARQ flip
"Loftus, Ciara" <[email protected]>
| Newsgroups | org.dpdk.dev |
|---|---|
| Message-ID | <IA4PR11MB927899DEA234EE61CB57610F8EDB2@IA4PR11MB9278.namprd11.prod.outlook.com> |
> Subject: [PATCH v2 5/7] net/iavf: improve VF reset detection on fast ARQ flip
>
> During PF-initiated reset or a remote/ToR switch link-flap,
> the PF toggles the admin receive queue enable bit (ARQLEN1)
> so quickly around a VF reset that the VF's sampling window
> misses it, leaving the PF and the VF states out of sync
> and the data path stalled.
>
> Complement the ARQLEN1 check with VFGEN_RSTAT
> (VIRTCHNL_VFR_INPROGRESS) and shorten the poll interval to
> 5 ms (with a proportionally larger count, keeping the ~10 s
> budget), matching the Linux kernel iavf driver.
> When the VFR is still not observed, proceed with recovery
> instead of bailing out so the PF and the VF states converge.
Double space between "and" and "the"
>
> Fixes: ada64daa1a5b ("net/iavf: fix VF reset for flow director rule")
I think the above Fixes tag can be dropped
> Fixes: 80fb3c920458 ("net/iavf: fix crash on VF start")
Cc stable?
>
> Signed-off-by: Anurag Mandal <[email protected]>
Acked-by: Ciara Loftus <[email protected]>