Re: [PATCH v2 1/2] net/iavf: remove Tx LLDP dynfield method

Bruce Richardson <[email protected]>
Newsgroups org.dpdk.dev
Message-ID <[email protected]>
On Fri, Aug 14, 2026 at 12:37:52PM +0000, Ciara Loftus wrote:
> Prior to this commit two methods existed for triggering LLDP packet
> transmission in the driver: the dynamic mbuf field method and the mbuf
> packet-type method. This commit removes the dynamic mbuf field method. The
> dynfield method required applications to tag every LLDP packet manually,
> whereas the packet-type method gives the driver the opportunity to tag LLDP
> packets automatically on the Rx path, leaving no work to be done by the
> application to explicitly flag a packet as LLDP before transmission.
> 
> The per-queue LLDP state is reduced from the tri-state 'lldp_mode' to a
> single 'lldp_enabled' boolean. The testpmd command 'set tx lldp on'
> whose purpose was to enable the dynfield lldp method is removed. The
> ptype lldp method is enabled via the enable_ptype_lldp devarg (as has
> always been the case since support was introduced):
> 
> 	-a 0000:xx:xx.x,enable_ptype_lldp=1
> 
> The deprecation notice for the dynfield is removed and the driver
> documentation is updated.
> 
> Signed-off-by: Ciara Loftus <[email protected]>
> Acked-by: Bruce Richardson <[email protected]>
> ---
> * Added warning if dynfield is registered
> ---
>  doc/guides/nics/intel_vf.rst                  | 29 +--------
>  doc/guides/rel_notes/deprecation.rst          |  4 --
>  doc/guides/rel_notes/release_26_11.rst        |  5 ++
>  drivers/net/intel/common/tx.h                 |  2 +-
>  drivers/net/intel/iavf/iavf_ethdev.c          | 30 ++-------
>  drivers/net/intel/iavf/iavf_rxtx.c            | 15 ++---
>  drivers/net/intel/iavf/iavf_rxtx.h            | 17 +-----
>  drivers/net/intel/iavf/iavf_rxtx_vec_avx2.c   | 22 +++----
>  drivers/net/intel/iavf/iavf_rxtx_vec_avx512.c | 22 +++----
>  drivers/net/intel/iavf/iavf_testpmd.c         | 61 -------------------
>  10 files changed, 47 insertions(+), 160 deletions(-)
> 
Patchset applied to dpdk-next-net-intel

Thanks,
/Bruce
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.