Re: [PATCH v2 00/14] Introduce RTE_DIV_ROUND_UP

Stephen Hemminger <[email protected]>
Newsgroups org.dpdk.dev
Message-ID <[email protected]>
On Thu, 13 Aug 2026 10:22:25 -0700
Joshua Washington <[email protected]> wrote:

> Numerous drivers independently define the DIV_ROUND_UP macro, using the
> same definition. Attempt to commonize by introducing RTE_DIV_ROUND_UP to
> rte_common.h and replacing usages of DIV_ROUND_UP with RTE_DIV_ROUND_UP.
> 
> Changes in v2:
>   - Split single patch into series.
> 
> Joshua Washington (14):
>   eal: introduce division round up macro
>   net/i40e: use common division round up macro
>   net/idpf: use common division round up macro
>   net/ice: use common division round up macro
>   net/qede: use common division round up macro
>   net/rnp: use common division round up macro
>   net/hns3: use common division round up macro
>   net/hinic: use common division round up macro
>   net/bnx2x: use common division round up macro
>   net/cxgbe: use common division round up macro
>   net/ena: use common division round up macro
>   raw/ifpga/base: use common division round up macro
>   drivers: use common division round up macro
>   app/procinfo: use common division round up macro
> 
>  app/proc-info/main.c                        |  3 +--
>  drivers/common/nfp/nfp_platform.h           |  2 --
>  drivers/net/bnx2x/bnx2x.c                   |  4 ++--
>  drivers/net/bnx2x/bnx2x.h                   | 11 ++++-------
>  drivers/net/cxgbe/base/t4_hw.c              |  4 ++--
>  drivers/net/cxgbe/base/t4vf_hw.c            | 10 +++++-----
>  drivers/net/cxgbe/cxgbe_compat.h            |  3 +--
>  drivers/net/cxgbe/cxgbe_filter.c            |  6 +++---
>  drivers/net/cxgbe/cxgbe_ofld.h              |  4 ++--
>  drivers/net/cxgbe/sge.c                     | 14 +++++++-------
>  drivers/net/ena/base/ena_eth_com.h          |  4 ++--
>  drivers/net/ena/base/ena_plat_dpdk.h        |  1 -
>  drivers/net/hinic/base/hinic_compat.h       |  5 +----
>  drivers/net/hns3/hns3_ethdev.h              |  2 --
>  drivers/net/hns3/hns3_fdir.c                |  2 +-
>  drivers/net/hns3/hns3_regs.c                |  8 ++++----
>  drivers/net/hns3/hns3_rss.c                 |  8 ++++----
>  drivers/net/intel/i40e/base/i40e_osdep.h    |  3 +--
>  drivers/net/intel/ice/base/ice_osdep.h      |  3 +--
>  drivers/net/intel/idpf/base/idpf_osdep.h    |  3 +--
>  drivers/net/nfp/nfdk/nfp_nfdk.h             |  5 +++--
>  drivers/net/nfp/nfdk/nfp_nfdk_dp.c          |  3 ++-
>  drivers/net/nfp/nfpcore/nfp_nsp.c           |  2 +-
>  drivers/net/qede/base/bcm_osal.h            |  2 --
>  drivers/net/qede/base/ecore_chain.h         |  2 +-
>  drivers/net/qede/base/ecore_cxt.c           | 20 +++++++++++---------
>  drivers/net/qede/base/ecore_init_fw_funcs.c | 21 ++++++++++++---------
>  drivers/net/qede/base/ecore_mcp.c           |  6 +++---
>  drivers/net/qede/qede_debug.c               | 16 ++++++++--------
>  drivers/net/rnp/base/rnp_osdep.h            |  5 ++---
>  drivers/net/rnp/rnp_rxtx.c                  |  2 +-
>  drivers/raw/ifpga/base/opae_osdep.h         |  3 +--
>  lib/eal/include/rte_common.h                |  5 +++++
>  33 files changed, 92 insertions(+), 100 deletions(-)
> 

Looks good, the only feedback from AI runs were noise
about blank lines etc.

Reviewed-by: Stephen Hemminger <[email protected]>
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.