Re: [PATCH v11 0/4] net/zxdh: optimize Rx/Tx path performance
Stephen Hemminger <[email protected]>
| Newsgroups | org.dpdk.dev |
|---|---|
| Message-ID | <[email protected]> |
On Wed, 19 Aug 2026 17:52:59 +0800 Junlong Wang <[email protected]> wrote: > v11: > - Restructure queue types for cache locality and dead-code removal (patch 2/4), > optimize the packed-ring Rx path with a single-segment fast path, > MTU/scatter refactor, and xstats cleanup (patch 3/4), and rework the > packed-ring Tx flush with per-descriptor mbuf free, walk budget, and > masked prefetch index (patch 4/4). Mostly ready, one more item flagged by AI review. Sorry, for the typical AI flowery language here... One item remains: Warning -- patch 3/4 adds "uint64_t offloads;" to struct zxdh_virtnet_rx (zxdh_rxtx.h). Patch 4/4's commit message says it "drop[s] the unused uint64_t offloads field from struct zxdh_virtnet_rx," but 4/4 never touches zxdh_rxtx.h -- the field is still in the tree at the end of the series. It has no readers or writers anywhere in the driver. Since patch 2/4 reorganised these structs specifically for cache locality, please either drop the field where it's introduced (3/4) or actually remove it in 4/4 so the commit log matches the diff.