Re: [PATCH] drm/amd/display: Silence link_dpms I2C retimer failures

Applied.  Thanks!

On Mon, Jul 27, 2026 at 12:11 PM Alan Swanson <[email protected]> wrote:
>
> Commit a4f01bf729b2 ("drm/amd/display: Refactor and fix link_dpms I2C")
> had also changed the "Set retimer failed" messages from DC_LOG_DEBUG()
> to DC_LOG_ERROR(). This unfortunately can create log spam.
>
> Change those back to DC_LOG_DEBUG() only.
>
> Closes: https://gitlab.freedesktop.org/drm/amd/-/work_items/5520
> Signed-off-by: Alan Swanson <[email protected]>
> ---
>  drivers/gpu/drm/amd/display/dc/link/link_dpms.c | 16 ++++++++--------
>  1 file changed, 8 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/link/link_dpms.c b/drivers/gpu/drm/amd/display/dc/link/link_dpms.c
> index 335ae952ef..1f7060ed49 100644
> --- a/drivers/gpu/drm/amd/display/dc/link/link_dpms.c
> +++ b/drivers/gpu/drm/amd/display/dc/link/link_dpms.c
> @@ -384,7 +384,7 @@ static bool write_i2c_retimer_vga(
>
>         for (size_t i = 0; i < ARRAY_SIZE(vga_data); i++) {
>                 if (!write_i2c_retimer_offset_value(link, address, vga_data[i][0], vga_data[i][1])) {
> -                       DC_LOG_ERROR("Set retimer failed, vga index: %zu\n", i);
> +                       DC_LOG_DEBUG("Set retimer failed, vga index: %zu\n", i);
>                         return false;
>                 }
>         }
> @@ -405,7 +405,7 @@ static bool write_i2c_retimer_byte(
>                 return true;
>
>         if (!write_i2c_retimer_offset_value(link, address, index, value)) {
> -               DC_LOG_ERROR("Set retimer failed, 3g index: 0x%x, value: 0x%x\n", index, value);
> +               DC_LOG_DEBUG("Set retimer failed, 3g index: 0x%x, value: 0x%x\n", index, value);
>                 return false;
>         }
>
> @@ -421,14 +421,14 @@ static bool write_i2c_retimer_byte(
>                         if (!link_query_ddc_data(
>                                         link->ddc, address, &offset, 1, &value, 1
>                         )) {
> -                               DC_LOG_ERROR("Set retimer failed, link_query_ddc_data\n");
> +                               DC_LOG_DEBUG("Set retimer failed, link_query_ddc_data\n");
>                                 return false;
>                         }
>                 }
>
>                 value |= apply_rx_tx_change;
>                 if (!write_i2c_retimer_offset_value(link, address, offset, value)) {
> -                       DC_LOG_ERROR("Set retimer failed, 3g offset: 0x%x, value: 0x%x\n", offset, value);
> +                       DC_LOG_DEBUG("Set retimer failed, 3g offset: 0x%x, value: 0x%x\n", offset, value);
>                         return false;
>                 }
>         }
> @@ -449,7 +449,7 @@ static bool write_i2c_retimer_setting(
>                 uint8_t value = settings->reg_settings[i].i2c_reg_val;
>
>                 if (!write_i2c_retimer_byte(link, address, index, value)) {
> -                       DC_LOG_ERROR("Set retimer failed, index: %zu\n", i);
> +                       DC_LOG_DEBUG("Set retimer failed, index: %zu\n", i);
>                         return false;
>                 }
>         }
> @@ -460,7 +460,7 @@ static bool write_i2c_retimer_setting(
>                         uint8_t value = settings->reg_settings_6g[i].i2c_reg_val;
>
>                         if (!write_i2c_retimer_byte(link, address, index, value)) {
> -                               DC_LOG_ERROR("Set retimer failed, 6g index: %zu\n", i);
> +                               DC_LOG_DEBUG("Set retimer failed, 6g index: %zu\n", i);
>                                 return false;
>                         }
>                 }
> @@ -492,7 +492,7 @@ static bool write_i2c_default_retimer_setting(
>
>         for (size_t i = 0; i < ARRAY_SIZE(data); i++) {
>                 if (!write_i2c_retimer_offset_value(link, address, data[i][0], data[i][1])) {
> -                       DC_LOG_ERROR("Set default retimer failed, index: %zu\n", i);
> +                       DC_LOG_DEBUG("Set default retimer failed, index: %zu\n", i);
>                         return false;
>                 }
>         }
> @@ -524,7 +524,7 @@ static bool write_i2c_redriver_setting(
>         );
>
>         if (!success)
> -               DC_LOG_ERROR("Set redriver failed");
> +               DC_LOG_DEBUG("Set redriver failed");
>         return success;
>  }
>
> --
> 2.54.0
>