Re: [PATCH] drm/amdgpu: Consistently define pci_device_ids using named initializers

Alex Deucher <[email protected]> Mon, 27 Jul 2026 12:46:30 -0400
Newsgroups org.freedesktop.lists.amd-gfx,org.freedesktop.lists.dri-devel,org.kernel.vger.linux-kernel
Message-ID <CADnq5_PtuGS_FXJJB6kh_xVUPFDXznLQbKuAGZN+choXhPTH9w@mail.gmail.com>
Applied.  Thanks.

Alex

On Mon, Jul 20, 2026 at 7:44 AM Uwe Kleine-König (The Capable Hub)
<[email protected]> wrote:
>
> Hello,
>
> On Wed, Jun 10, 2026 at 06:55:09PM +0200, Uwe Kleine-König (The Capable Hub) wrote:
> > On Wed, Apr 29, 2026 at 07:16:44PM +0200, Uwe Kleine-König (The Capable Hub) wrote:
> > > ... and PCI device helpers.
> > >
> > > The struct pci_device_id array of supported device was initialized
> > > by list expressions. This isn't easily readable if you're not into PCI.
> > >
> > > Use PCI_DEVICE* helper macros and named initializers which is more
> > > explicit and thus easier to parse. Also skip explicit assignments of 0
> > > (which the compiler then takes care of).
> > >
> > > The secret plan is to make struct pci_device_id::driver_data an
> > > anonymous union (similar to
> > > https://lore.kernel.org/all/[email protected]/)
> > > and that requires named initializers. But it's also a nice cleanup on
> > > its own.
> > >
> > > This change doesn't introduce changes to the compiled pci_device_id
> > > array. Tested on x86 and arm64.
> > >
> > > Signed-off-by: Uwe Kleine-König (The Capable Hub) <[email protected]>
> >
> > Gentil ping! I'd like to work on changing pci_device_id, but that
> > requires that this patch hits mainline first ...
>
> Would it help to resend? Did I fail to Cc: someone to get this patch
> into some tracking?
>
> Best regards
> Uwe