Re: [PATCH] drm/amdgpu/gmc12.1: fix MMHUB0 check in pasid tlb flush

Alex Deucher <[email protected]> Tue, 4 Aug 2026 10:11:43 -0400
Newsgroups org.freedesktop.lists.amd-gfx
Message-ID <CADnq5_M3YV1OhEtYUY9Ym5w7FqnVYvsV1WAFBNVSJgC3gwmgxQ@mail.gmail.com>
Gentle ping?

On Fri, Jul 31, 2026 at 10:05=E2=80=AFAM Alex Deucher <[email protected]=
m> wrote:
>
> Ping?
>
> On Tue, Jul 28, 2026 at 11:48=E2=80=AFAM Alex Deucher <alexander.deucher@=
amd.com> wrote:
> >
> > Check for mmhub0 rather than mmhub1.  Looks like a copy
> > paste typo.
> >
> > Fixes: d0c989a0aad3 ("drm/amd/amdgpu : Use the MES INV_TLBS API for tlb=
 invalidation on gfx12_1")
> > Cc: Shaoyun Liu <[email protected]>
> > Signed-off-by: Alex Deucher <[email protected]>
> > ---
> >  drivers/gpu/drm/amd/amdgpu/gmc_v12_1.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/amd/amdgpu/gmc_v12_1.c b/drivers/gpu/drm/a=
md/amdgpu/gmc_v12_1.c
> > index 855cd29cbffaa..54a5e64f53b3b 100644
> > --- a/drivers/gpu/drm/amd/amdgpu/gmc_v12_1.c
> > +++ b/drivers/gpu/drm/amd/amdgpu/gmc_v12_1.c
> > @@ -396,7 +396,7 @@ static void gmc_v12_1_flush_gpu_tlb_pasid(struct am=
dgpu_device *adev,
> >
> >                 if (all_hub) {
> >                         /* invalidate mm_hub */
> > -                       if (test_bit(AMDGPU_MMHUB1(0), adev->vmhubs_mas=
k)) {
> > +                       if (test_bit(AMDGPU_MMHUB0(0), adev->vmhubs_mas=
k)) {
> >                                 input.hub_id =3D AMDGPU_MMHUB0(0);
> >                                 adev->mes.funcs->invalidate_tlbs_pasid(=
&adev->mes, &input);
> >                         }
> > --
> > 2.55.0
> >