Re: [PATCH 2/3] drm/amdgpu: fix missing check in vm_flush()

On 8/10/26 17:58, Alex Deucher wrote:
> [You don't often get email from [email protected]. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ]
>
> + David
>
> Ping?
>
> On Fri, Aug 7, 2026 at 9:04 AM Alex Deucher <[email protected]> wrote:
>> Ping?
>>
>> Alex
>>
>> On Fri, Jun 5, 2026 at 6:44 PM Alex Deucher <[email protected]> wrote:
>>> We shouldn't return early if we need to emit spm update.
>>>
>>> Signed-off-by: Alex Deucher <[email protected]>

It may be better to move
+       spm_update_needed &= !!adev->gfx.rlc.funcs->update_spm_vmid;
from the 3rd patch here.

Reviewed-by: David Rosca <[email protected]>

>>> ---
>>>   drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 2 +-
>>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
>>> index 7e0e2281719b1..13031e4b6f1d5 100644
>>> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
>>> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
>>> @@ -809,7 +809,7 @@ void amdgpu_vm_flush(struct amdgpu_ring *ring, struct amdgpu_job *job,
>>>                  &job->base.s_fence->scheduled == isolation->spearhead;
>>>
>>>          if (!vm_flush_needed && !gds_switch_needed && !need_pipe_sync &&
>>> -           !cleaner_shader_needed)
>>> +           !cleaner_shader_needed && !spm_update_needed)
>>>                  return;
>>>
>>>          amdgpu_ring_ib_begin(ring);
>>> --
>>> 2.54.0
>>>