Re: [PATCH] amdkfd: let profile_lock_device return an int other than uint32

On 2026-08-14 02:53, Zhu Lingshan wrote:
> profile_lock_device() may return negive error code,
> so the type of the return value should be int,
> not uint32
>
> Signed-off-by: Zhu Lingshan <[email protected]>

Reviewed-by: Felix Kuehling <[email protected]>


> ---
>   drivers/gpu/drm/amd/amdkfd/kfd_chardev.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_chardev.c b/drivers/gpu/drm/amd/amdkfd/kfd_chardev.c
> index 309510e23315..6fd18488d5cf 100644
> --- a/drivers/gpu/drm/amd/amdkfd/kfd_chardev.c
> +++ b/drivers/gpu/drm/amd/amdkfd/kfd_chardev.c
> @@ -3329,7 +3329,7 @@ static int kfd_ioctl_create_process(struct file *filep, struct kfd_process *p, v
>   	return 0;
>   }
>   
> -static inline uint32_t profile_lock_device(struct kfd_process *p,
> +static inline int profile_lock_device(struct kfd_process *p,
>   					   uint32_t gpu_id, uint32_t op)
>   {
>   	struct kfd_process_device *pdd;