Re: [PATCH v4 0/1] drm/amdkfd: Add TLB flush after MES queue eviction/suspension

On 16-Aug-26 10:56 PM, Priya Hosur wrote:
> This patch adds heavy-weight TLB flush after MES queue eviction/suspension
> to fix SVM page migration hangs on gfx1151 with XNACK mode enabled.
> 
> v4:
>    - Dropped userq TLB flush patch per Felix/Lijo feedback: TLB flush is only
>      needed after batch unmap in amdgpu_userq_unmap_all(), not per-queue unmap
> 

Sorry, that was not the intention. I was thinking there is a unmap_all 
API in MES in which case this could be done within FW itself instead.

I believe Alex was also asking to check about batch unmap cases of user 
queue. Ex: - amdgpu_eviction_fence_suspend_worker there could still be 
inflight transactions similar to KFD case.

Thanks,
Lijo

> v3:
>    - Split into 2 patches per Alex's review
>    - Added userq TLB flush in amdgpu_userq_unmap_helper() (amdgpu_userq.c)
> 
> v2:
>    - Removed "SDMA" from comment as this affects all in-flight memory
>      accesses, not just SDMA (Felix Kuehling)
>    - Added Reviewed-by tag
> 
> Priya Hosur (1):
>    drm/amdkfd: Add TLB flush after MES queue eviction/suspension
> 
>   .../drm/amd/amdkfd/kfd_device_queue_manager.c | 10 ++++++++++
>   1 file changed, 10 insertions(+)
>