Re: [PATCH] drm/amdgpu: add missing nbio_v7_11_5 callback

On Mon, Aug 17, 2026 at 1:30 AM Shubhankar Milind Sardeshpande
<[email protected]> wrote:
>
> Add get_clockgating_state() since the missing
> get_clockgating_state() caused a NULL pointer dereference when reading
> the amdgpu_pm_info debugfs node.
>
> Fixes: 0453ccd3237a ("drm/amdgpu: Add NBIO 7.11.5 support")
>
> Signed-off-by: Shubhankar Milind Sardeshpande <[email protected]>

Acked-by: Alex Deucher <[email protected]>

> ---
>  drivers/gpu/drm/amd/amdgpu/nbio_v7_11_5.c | 7 +++++++
>  1 file changed, 7 insertions(+)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/nbio_v7_11_5.c b/drivers/gpu/drm/amd/amdgpu/nbio_v7_11_5.c
> index 9bb998a47ef6..0ea6e091a24c 100644
> --- a/drivers/gpu/drm/amd/amdgpu/nbio_v7_11_5.c
> +++ b/drivers/gpu/drm/amd/amdgpu/nbio_v7_11_5.c
> @@ -249,6 +249,12 @@ static void nbio_v7_11_5_ih_control(struct amdgpu_device *adev)
>                 WREG32_SOC15(NBIO, 0, regBIF_BX1_INTERRUPT_CNTL, interrupt_cntl);
>  }
>
> +static void
> +nbio_v7_11_5_get_clockgating_state(struct amdgpu_device *adev,
> +                                 u64 *flags)
> +{
> +}
> +
>  static u32 nbio_v7_11_5_get_hdp_flush_req_offset(struct amdgpu_device *adev)
>  {
>         u32 offset;
> @@ -337,6 +343,7 @@ const struct amdgpu_nbio_funcs nbio_v7_11_5_funcs = {
>         .enable_doorbell_aperture = nbio_v7_11_5_enable_doorbell_aperture,
>         .enable_doorbell_selfring_aperture = nbio_v7_11_5_enable_doorbell_selfring_aperture,
>         .ih_doorbell_range = nbio_v7_11_5_ih_doorbell_range,
> +       .get_clockgating_state = nbio_v7_11_5_get_clockgating_state,
>         .ih_control = nbio_v7_11_5_ih_control,
>         .init_registers = nbio_v7_11_5_init_registers,
>         .remap_hdp_registers = nbio_v7_11_5_remap_hdp_registers,
> --
> 2.43.0
>