RE: [PATCH] drm/amd/ras: Remove unguarded asm/mce.h include

"Deucher, Alexander" <[email protected]>
Newsgroups org.freedesktop.lists.amd-gfx
Message-ID <BN9PR12MB5146DF50BF07262460A04A5FF7A52@BN9PR12MB5146.namprd12.prod.outlook.com>
Public

> -----Original Message-----
> From: amd-gfx <[email protected]> On Behalf Of
> [email protected]
> Sent: Wednesday, August 19, 2026 11:02 AM
> To: [email protected]; Deucher, Alexander
> <[email protected]>
> Cc: LIPSKI, IVAN <[email protected]>; Chai, Thomas
> <[email protected]>; Zhang, Hawking <[email protected]>; Qi,
> Tony <[email protected]>
> Subject: [PATCH] drm/amd/ras: Remove unguarded asm/mce.h include
>
> From: Tony Qi <[email protected]>
>
> asm/mce.h is x86-only, so the unconditional include broke non-x86 builds
> with "fatal error: asm/mce.h: No such file or directory". The header is already
> included under CONFIG_X86_MCE_AMD with the code that uses it, so remove
> the redundant unguarded copy.
>
> Fixes: 1c46b6971260 ("drm/amd/ras: Isolate ras mce handler with
> CONFIG_X86_MCE_AMD")
>
> Signed-off-by: Tony Qi <[email protected]>

Reviewed-by: Alex Deucher <[email protected]>

> ---
>  drivers/gpu/drm/amd/ras/ras_mgr/amdgpu_ras_mce.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/ras/ras_mgr/amdgpu_ras_mce.c
> b/drivers/gpu/drm/amd/ras/ras_mgr/amdgpu_ras_mce.c
> index ad978ed45843..0edb3dc06a69 100644
> --- a/drivers/gpu/drm/amd/ras/ras_mgr/amdgpu_ras_mce.c
> +++ b/drivers/gpu/drm/amd/ras/ras_mgr/amdgpu_ras_mce.c
> @@ -25,7 +25,6 @@
>  #include "amdgpu.h"
>  #include "amdgpu_ras_mgr.h"
>  #include "amdgpu_ras_mce.h"
> -#include <asm/mce.h>
>
>  #ifdef CONFIG_X86_MCE_AMD
>  #include <asm/mce.h>
> --
> 2.43.0
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.