Re: [PATCH 2/2] drm/amd/display: Log details when failing to register HPD IRQ

On 8/21/26 16:50, Timur Kristóf wrote:
> This should help diagnose HPD IRQ related issues in the future.
> 
> Signed-off-by: Timur Kristóf <[email protected]>
Reviewed-by: Mario Limonciello (AMD) <[email protected]>

I'll get this committed to amd-staging-drm-next.

> ---
>   drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_irq.c | 8 ++++++--
>   1 file changed, 6 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_irq.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_irq.c
> index 9be63996b062..d0239a3de2e1 100644
> --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_irq.c
> +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_irq.c
> @@ -1735,7 +1735,9 @@ int amdgpu_dm_register_hpd_handlers(struct amdgpu_device *adev)
>   			if (int_params.irq_source == DC_IRQ_SOURCE_INVALID ||
>   				int_params.irq_source  < DC_IRQ_SOURCE_HPD1 ||
>   				int_params.irq_source  > DC_IRQ_SOURCE_HPD6) {
> -				drm_err(adev_to_drm(adev), "Failed to register hpd irq!\n");
> +				drm_err(adev_to_drm(adev),
> +					"Failed to register hpd irq %u for %s!\n",
> +					int_params.irq_source, connector->name);
>   				return -EINVAL;
>   			}
>   
> @@ -1753,7 +1755,9 @@ int amdgpu_dm_register_hpd_handlers(struct amdgpu_device *adev)
>   			if (int_params.irq_source == DC_IRQ_SOURCE_INVALID ||
>   				int_params.irq_source  < DC_IRQ_SOURCE_HPD1RX ||
>   				int_params.irq_source  > DC_IRQ_SOURCE_HPD6RX) {
> -				drm_err(adev_to_drm(adev), "Failed to register hpd rx irq!\n");
> +				drm_err(adev_to_drm(adev),
> +					"Failed to register hpd rx irq %u for %s!\n",
> +					int_params.irq_source, connector->name);
>   				return -EINVAL;
>   			}
>