Re: [PATCH] drm/amdgpu: return reserve errors from amdgpu_gfx_kiq_init()

Runyu Xiao <[email protected]>
Newsgroups org.freedesktop.lists.amd-gfx,org.freedesktop.lists.dri-devel,org.kernel.vger.linux-kernel,org.kernel.vger.stable
Message-ID <[email protected]>
Thanks for the review.

Before preparing a resend, I rechecked the reservation path:

  amdgpu_bo_reserve(bo, true)
    -> ttm_bo_reserve(bo, false, false, NULL)
    -> dma_resv_lock(...)

This is an uninterruptible, blocking lock acquisition without a ww acquire
context. Under the current locking semantics, contention is waited out and
the call cannot normally return -EINTR, -EBUSY, -EDEADLK, or -EALREADY.

The reserve-failure path targeted by this patch is therefore not reachable
under the current locking semantics, and this patch does not address a
currently triggerable bug.

I am withdrawing the patch and will not send a v2. Thanks for catching this.

Runyu Xiao
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.