Re: [PATCH] drm/amdgpu/gfx8: only apply compute quantums to KCQs
Alex Deucher <[email protected]>
| Newsgroups | org.freedesktop.lists.amd-gfx |
|---|---|
| Message-ID | <CADnq5_PoahpM1GB-fum5rYgzrS2sA=bfpdWjb3m=iutxtX9J3A@mail.gmail.com> |
Ping? On Thu, Aug 20, 2026 at 10:10 AM Alex Deucher <[email protected]> wrote: > > Don't apply to KIQ. Seems to cause problems on KIQ > on some ARM platforms. > > Closes: https://gitlab.freedesktop.org/drm/amd/-/work_items/5658 > Fixes: 91cf34bc5a55 ("drm/amdgpu/gfx8: align mqd settings with KFD") > Signed-off-by: Alex Deucher <[email protected]> > --- > drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c | 8 +++++--- > 1 file changed, 5 insertions(+), 3 deletions(-) > > diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c b/drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c > index f7c2b149acd0a..4241453e0ec8b 100644 > --- a/drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c > +++ b/drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c > @@ -4546,9 +4546,11 @@ static int gfx_v8_0_mqd_init(struct amdgpu_ring *ring) > /* set static priority for a queue/ring */ > gfx_v8_0_mqd_set_priority(ring, mqd); > tmp = RREG32(mmCP_HQD_QUANTUM); > - tmp = REG_SET_FIELD(tmp, CP_HQD_QUANTUM, QUANTUM_EN, 1); > - tmp = REG_SET_FIELD(tmp, CP_HQD_QUANTUM, QUANTUM_SCALE, 1); > - tmp = REG_SET_FIELD(tmp, CP_HQD_QUANTUM, QUANTUM_DURATION, 10); > + if (ring != &adev->gfx.kiq[0].ring) { > + tmp = REG_SET_FIELD(tmp, CP_HQD_QUANTUM, QUANTUM_EN, 1); > + tmp = REG_SET_FIELD(tmp, CP_HQD_QUANTUM, QUANTUM_SCALE, 1); > + tmp = REG_SET_FIELD(tmp, CP_HQD_QUANTUM, QUANTUM_DURATION, 10); > + } > mqd->cp_hqd_quantum = tmp; > > /* map_queues packet doesn't need activate the queue, > -- > 2.55.0 >