RE: [PATCH 3/3] drm/amd/ras: report the banks the scrubber logged

AMD General

Series is

Reviewed-by: Hawking Zhang <[email protected]>

Regards,
Hawking
-----Original Message-----
From: Liu, Xiang(Dean) <[email protected]>
Sent: Wednesday, August 26, 2026 11:26 AM
To: [email protected]
Cc: Zhang, Hawking <[email protected]>; Zhou1, Tao <[email protected]>; Yang, Stanley <[email protected]>; Chai, Thomas <[email protected]>; Liu, Xiang(Dean) <[email protected]>
Subject: [PATCH 3/3] drm/amd/ras: report the banks the scrubber logged

A bank carrying the scrub bit was found by the background scrubber rather than by an access, which is worth telling apart from the rest when reading a log.

Signed-off-by: Xiang Liu <[email protected]>
---
 drivers/gpu/drm/amd/ras/core/aca.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/drivers/gpu/drm/amd/ras/core/aca.c b/drivers/gpu/drm/amd/ras/core/aca.c
index b40098406174..881681ea9f3f 100644
--- a/drivers/gpu/drm/amd/ras/core/aca.c
+++ b/drivers/gpu/drm/amd/ras/core/aca.c
@@ -128,6 +128,11 @@ static void aca_bank_log(struct ras_core_context *ras_core,
                        "{%llu}" RAS_HW_ERR "ACA[%02d/%02d].%s=0x%016llx\n",
                        bank->seq_no, idx + 1, total,
                        aca_regs[i].name, bank->regs[aca_regs[i].reg_idx]);
+
+       if (ACA_REG_STATUS_SCRUB(bank->regs[ACA_REG_IDX__STATUS]))
+               RAS_DEV_INFO(ras_core->dev,
+                       "{%llu}" RAS_HW_ERR "hardware error logged by the scrubber\n",
+                       bank->seq_no);
 }

 static void aca_log_bank_data(struct ras_core_context *ras_core,
--
2.34.1