Re: [PATCH] drm/amdgpu: use hyphens in TLB fence driver and timeline names

On 8/25/26 10:15, Prike Liang wrote:
> Replace spaces with hyphens in amdgpu_tlb_fence_get_driver_name() and
> amdgpu_tlb_fence_get_timeline_name(). Returning string literals with
> spaces makes ftrace fence events and debugfs fence entries visually
> ambiguous and harder to parse using standard log analysis tools.

Interesting, I never considered that a problem.

> 
> Signed-off-by: Prike Liang <[email protected]>

Acked-by: Christian König <[email protected]>

> ---
>  drivers/gpu/drm/amd/amdgpu/amdgpu_vm_tlb_fence.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm_tlb_fence.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm_tlb_fence.c
> index 82b8badde453..b0002c898386 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm_tlb_fence.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm_tlb_fence.c
> @@ -40,12 +40,12 @@ struct amdgpu_tlb_fence {
>  
>  static const char *amdgpu_tlb_fence_get_driver_name(struct dma_fence *fence)
>  {
> -	return "amdgpu tlb fence";
> +	return "amdgpu_tlb_fence";
>  }
>  
>  static const char *amdgpu_tlb_fence_get_timeline_name(struct dma_fence *f)
>  {
> -	return "amdgpu tlb timeline";
> +	return "amdgpu_tlb_timeline";
>  }
>  
>  static void amdgpu_tlb_fence_work(struct work_struct *work)