Thank you for your contribution! Sashiko AI review found 3 potential issue(s) to consider:
- [Low] The newly added device tree source `sm8250-xiaomi-enuma.dts` fails to compile because it references an undefined label `&wifi_0`.
- [Low] The root `compatible` string violates the `qcom.yaml` schema expectations and will fail `make dtbs_check`.
- [Low] The display panel `compatible` string violates the `novatek,nt36523.yaml` schema expectations and will fail `make dtbs_check`.
--
--- Patch [4]: [PATCH 4/4] arm64: dts: qcom: sm8250: add device tree for the Xiaomi Mi Pad 5 Pro 5G ---
commit 3ad8e67e479446954f8eea3da616a9b04bf046b8
Author: Dawid Wróbel <[email protected]>
arm64: dts: qcom: sm8250: add device tree for the Xiaomi Mi Pad 5 Pro 5G
This patch adds a new device tree for the Xiaomi Mi Pad 5 Pro 5G (enuma),
which is the modem-equipped variant of the Mi Pad 5 Pro. It describes the
board using the common device tree along with its own board ID, panel
compatible, and WiFi board data variant.
> diff --git a/arch/arm64/boot/dts/qcom/sm8250-xiaomi-enuma.dts b/arch/arm64/boot/dts/qcom/sm8250-xiaomi-enuma.dts
> new file mode 100644
> index 0000000000000..7cc9ed7d12b28
> --- /dev/null
> +++ b/arch/arm64/boot/dts/qcom/sm8250-xiaomi-enuma.dts
> @@ -0,0 +1,26 @@
[ ... ]
> +/ {
> + model = "Xiaomi Mi Pad 5 Pro 5G";
> + compatible = "xiaomi,enuma", "xiaomi,elish", "qcom,sm8250";
[Severity: Low]
Does this root compatible string violate the qcom.yaml schema expectations?
It looks like it contains 3 items instead of the strictly expected 2, and
"xiaomi,enuma" is not documented in the schema, which could cause
make dtbs_check to fail.
> +
> + /* Platform type differs from elish; msm-id is inherited unchanged. */
> + qcom,board-id = <0x2e 0>;
> +};
> +
> +&display_panel {
> + compatible = "xiaomi,enuma-csot-nt36523", "xiaomi,elish-csot-nt36523",
> + "novatek,nt36523";
[Severity: Low]
Does this display panel compatible string violate the novatek,nt36523.yaml
schema expectations? It appears to contain 3 items instead of 2, and
"xiaomi,enuma-csot-nt36523" is not listed in the schema, which could cause
a make dtbs_check failure.
> + status = "okay";
> +};
> +
> +&wifi_0 {
[Severity: Low]
Is wifi_0 defined in any of the included files? It looks like this block
references an undefined label &wifi_0, which triggers a fatal dtc compile
error during make dtbs.
> + qcom,calibration-variant = "Xiaomi_Pad_5Pro_5G";
> +};
--
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=4
lmpx.com only provides a reader for public news (NNTP) servers. It is not
affiliated with the servers or forums shown here and is not responsible for
the content of articles, which is written by their respective authors.