Re: [PATCH v2 1/5] fbdev: tdfxfb: Add helper to read config table from BIOS

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The patch introduces a static function `tdfxfb_get_bios_cfg` without calling it anywhere in the file, which will cause `-Wunused-function` compiler warnings.
--

--- Patch [1]: [PATCH v2 1/5] fbdev: tdfxfb: Add helper to read config table from BIOS ---
commit fa478291eec9e5fb1f0dff8fd28bbff72c80da86
Author: Daniel Palmer <[email protected]>

fbdev: tdfxfb: Add helper to read config table from BIOS

This commit adds a helper function to read the configuration table from the
video BIOS for Voodoo 3 cards. This is in preparation for manually booting
these cards in environments where the BIOS has not run.

> diff --git a/drivers/video/fbdev/tdfxfb.c b/drivers/video/fbdev/tdfxfb.c
> index cc6a074f3165b..e92658274411a 100644
> --- a/drivers/video/fbdev/tdfxfb.c
> +++ b/drivers/video/fbdev/tdfxfb.c
[ ... ]
> +static bool tdfxfb_get_bios_cfg(struct pci_dev *pdev,
> +				struct tdfx_bios_cfg *cfg)
> +{

[Severity: Low]
Does this new static function trigger a -Wunused-function compiler warning?

It doesn't appear to be called anywhere in this patch. Introducing an
unreferenced static function usually causes build failures on configurations
where warnings are treated as errors (CONFIG_WERROR=y). 

Should this helper be added in the same patch that starts using it, or
perhaps marked with __maybe_unused to prevent the warning in the interim?

> +	u16 romcfg, oemcfg;
> +	void __iomem *rom;
[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=1