Re: [PATCH 0/2] drm/imagination: Tidy-up firmware interface checks

Brajesh Gupta <[email protected]> Mon, 3 Aug 2026 06:41:23 +0000
Newsgroups org.freedesktop.lists.dri-devel,org.kernel.vger.linux-kernel
Message-ID <[email protected]>
On Wed, 2026-07-29 at 15:57 +0100, Alessio Belle wrote:
Hi Alessio,
> *** NOTE: This is an internal email from Imagination Technologies ***
> 
> 
> 
> 
> The same macros were repeated in multiple header files, and another
> header that could have used them, didn't.
> Move things around to to sort out these minor issues.
> 
> Strict checkpatch reports "Macro argument reuse 'member' - possible
> side-effects?" for FLEX_ARRAY_CHECK() but that's not a problem here.

For the whole series:
Reviewed-by: Brajesh Gupta <[email protected]>

Thanks,
Brajesh
> 
> 
> Signed-off-by: Alessio Belle <[email protected]>
> ---
> Alessio Belle (1):
>       drm/imagination: Reuse layout check macros for MIPS FW structures
> 
> Alexandru Dadu (1):
>       drm/imagination: Move all FW interface check macros to pvr_checks.h
> 
>  drivers/gpu/drm/imagination/pvr_check.h            | 36 +++++++++++
>  drivers/gpu/drm/imagination/pvr_rogue_fwif_check.h | 26 +-------
>  .../drm/imagination/pvr_rogue_fwif_client_check.h  |  9 +--
>  .../drm/imagination/pvr_rogue_fwif_shared_check.h  |  9 +--
>  drivers/gpu/drm/imagination/pvr_rogue_mips_check.h | 71 ++++++++--------------
>  5 files changed, 63 insertions(+), 88 deletions(-)
> ---
> base-commit: e55fead22ff9ee047ab9f1903860c4b43043514e
> change-id: 20260729-fwif-checks-updates-52adf8657615
> 
> Best regards,
> --
> Alessio Belle <[email protected]>
>