Re: [PATCH v2 2/2] drm/komeda: Set display/writeback clone masks

On 03/08/2026 15:46, Liviu Dudau wrote:
> On Mon, Aug 03, 2026 at 03:21:22PM +0100, Raveendra Talabattula wrote:
>> From: Vincenzo Frascino <[email protected]>
>>
>> Since commit 41b4b11da0215 ("drm: Add valid clones check"),
>> all encoders attached to the same CRTC must advertise
>> each other through possible_clones.
>>
>> Komeda creates one writeback connector per CRTC. Allow the writeback
>> encoder to be cloned only with encoders that can drive the same CRTC,
>> and update those encoders reciprocally.
>>
>> Do this when the writeback connector is created rather than modifying
>> every encoder registered with the DRM device from komeda_kms_attach().
>> This leaves encoders associated with other CRTCs untouched.
> 
> If you don't mind I will drop the paragraph above when I commit the patch
> as it makes reference to code that has not been merged so likely
> to create confusion. I think the comment in the code is sufficient.
> 

Of course Liviu, I mentioned it to make sure that it was clear I looked at the
code you mentioned in review.

We are happy to address the relevant changes once the new series gets merged.

Thanks,
Vincenzo

> With that,
> 
> Reviewed-by: Liviu Dudau <[email protected]>
> 
> Will push this to drm-misc-next in the next couple of days.
> 
> Best regards,
> Liviu
> ...