Re: [PATCH v1] drm/msm/dp: Disable stream clock after video-ready timeout
최유호 <[email protected]> Mon, 3 Aug 2026 14:21:58 -0400
| Newsgroups | org.freedesktop.lists.dri-devel,dev.linux.lists.sashiko-reviews,org.kernel.vger.linux-arm-msm,org.kernel.vger.linux-kernel |
|---|---|
| Message-ID | <CACrCO_UUX_A+Z7uCsT9=JkXqqkG0Tp=n0rXO3j+KAzNxGRuVQQ@mail.gmail.com> |
On Fri, 31 Jul 2026 at 10:05, Dmitry Baryshkov <[email protected]> wrote: > > On Tue, Jul 07, 2026 at 06:05:53PM +0000, [email protected] wrote: > > Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: > > - [High] Disabling the pixel clock while the DP controller is actively in the SEND_VIDEO state violates the teardown sequence and can lock up the hardware. > > -- > > Could you please comment on this Sashiko comment? Thanks, agreed. The posted patch disables the pixel clock before reverting the controller from SEND_VIDEO, and the bridge disable path may later issue PUSH_IDLE with the clock disabled. I will send the revised patch addressing the comment. I appreciate your time for the review. Thanks, Yuho