Re: [PATCH 07/12] drm/panthor: Add fine-grained restrictions on VMs

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The `bool unusable;` field was not removed from `struct panthor_as` despite its usage being entirely replaced by `atomic_t restrictions;`.
--

--- Patch [7]: [PATCH 07/12] drm/panthor: Add fine-grained restrictions on VMs ---
commit 5761524aad92664686f92656f3aec2cb543204a6
Author: Boris Brezillon <[email protected]>

drm/panthor: Add fine-grained restrictions on VMs

This commit replaces the existing boolean state checks with a unified atomic
bitmask for fine-grained VM restrictions. It introduces new restriction flags
representing operations to prevent (map, unmap, and use) and updates the
relevant usage paths to check against this bitmask.

> diff --git a/drivers/gpu/drm/panthor/panthor_mmu.c b/drivers/gpu/drm/panthor/panthor_mmu.c
> --- a/drivers/gpu/drm/panthor/panthor_mmu.c
> +++ b/drivers/gpu/drm/panthor/panthor_mmu.c
[ ... ]
> @@ -295,6 +314,9 @@ struct panthor_as {
>  	 */
>  	bool unusable;
>  
> +	/** @restrictions: Bitmask of panthor_as_restriction flags. */
> +	atomic_t restrictions;
> +

[Severity: Low]
This isn't a bug, but should the unusable field be removed from struct
panthor_as now that its functionality is entirely replaced by the newly
added restrictions field?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=7