Re: [PATCH 04/12] gpu: nova-core: mm: Add VramAddress type

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Nested import groups are used instead of the kernel vertical import style.
--

--- Patch [4]: [PATCH 04/12] gpu: nova-core: mm: Add VramAddress type ---
commit c94d87cb8d48e350527f7f52cc4f004c23fd4d17
Author: Joel Fernandes <[email protected]>

gpu: nova-core: mm: Add VramAddress type

This commit adds the VramAddress type to represent a physical address in
VRAM. It also includes arithmetic helpers, comparisons, and operator
overloads required for address arithmetic.

> diff --git a/drivers/gpu/nova-core/mm.rs b/drivers/gpu/nova-core/mm.rs
> new file mode 100644
> index 0000000000000..dcd5e5e919bf2
> --- /dev/null
> +++ b/drivers/gpu/nova-core/mm.rs
> @@ -0,0 +1,60 @@
> +// SPDX-License-Identifier: GPL-2.0
> +// SPDX-FileCopyrightText: Copyright (c) 2026 NVIDIA CORPORATION & AFFILIATES. All rights reserved.
> +
> +//! Memory management subsystems.
> +
> +#![expect(dead_code)]
> +
> +use core::{
> +    fmt::LowerHex,
> +    ops, //
> +};

[Severity: Low]
This isn't a bug, but does this follow the kernel vertical import style? 
According to the Rust coding guidelines, imports should be organized 
vertically rather than using nested import groups.

[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=4