Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The `memory-region` and `memory-region-names` properties were added to `nvidia,tegra234-nvdec.yaml` to support the Video Protection Region (VPR) for secure video decoding, but they were omitted from the related `nvidia,tegra210-nvdec.yaml` binding which covers earlier generations of the same hardware family.
--
--- Patch [3]: [PATCH v4 03/10] dt-bindings: gpu: host1x: Document memory-regions for NVDEC ---
commit 97ab5bd4094807d50abd7cf4f4dbbc00d0abb716
Author: Thierry Reding <[email protected]>
dt-bindings: gpu: host1x: Document memory-regions for NVDEC
This commit adds memory-region and memory-region-names properties to the
Tegra234 NVDEC binding. This allows device trees to define a reserved video
protection region for secure video playback.
> diff --git a/Documentation/devicetree/bindings/gpu/host1x/nvidia,tegra234-nvdec.yaml b/Documentation/devicetree/bindings/gpu/host1x/nvidia,tegra234-nvdec.yaml
> index 4eb325cfd2961..bcaaabca945dc 100644
> --- a/Documentation/devicetree/bindings/gpu/host1x/nvidia,tegra234-nvdec.yaml
> +++ b/Documentation/devicetree/bindings/gpu/host1x/nvidia,tegra234-nvdec.yaml
[ ... ]
> @@ -60,6 +60,14 @@ properties:
> - const: dma-mem
> - const: write
>
> + memory-region:
> + items:
> + - description: reference to the video protection memory region
> +
> + memory-region-names:
> + items:
> + - const: protected
> +
[Severity: Medium]
Since earlier generations of the hardware share this family, should these
properties also be added to nvidia,tegra210-nvdec.yaml?
Because nvidia,tegra210-nvdec.yaml specifies additionalProperties: false, if
older devices (like those using nvidia,tegra186-nvdec) configure the NVDEC
block to use the Video Protection Region by adding the memory-region property,
they will fail device tree schema validation.
> nvidia,memory-controller:
> $ref: /schemas/types.yaml#/definitions/phandle
> description:
--
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=3
lmpx.com only provides a reader for public news (NNTP) servers. It is not
affiliated with the servers or forums shown here and is not responsible for
the content of articles, which is written by their respective authors.