Re: [PATCH v2 69/78] drm/tidss: encoder: Switch to atomic_create_state

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Incomplete API migration in the tidss driver leaving a deprecated API in use.
--

--- Patch [69]: [PATCH v2 69/78] drm/tidss: encoder: Switch to atomic_create_state ---
commit 4b163072222fe41ca874889e053936b933e75ded
Author: Maxime Ripard <[email protected]>

drm/tidss: encoder: Switch to atomic_create_state

This commit updates the tidss driver to replace the deprecated atomic_reset
callback with atomic_create_state for the bridge functions.

> diff --git a/drivers/gpu/drm/tidss/tidss_encoder.c b/drivers/gpu/drm/tidss/tidss_encoder.c
> index 34db8d2a3792e..698f8d964ca00 100644
> --- a/drivers/gpu/drm/tidss/tidss_encoder.c
> +++ b/drivers/gpu/drm/tidss/tidss_encoder.c
> @@ -76,7 +76,7 @@ static int tidss_bridge_atomic_check(struct drm_bridge *bridge,
>  static const struct drm_bridge_funcs tidss_bridge_funcs = {
>  	.attach				= tidss_bridge_attach,
>  	.atomic_check			= tidss_bridge_atomic_check,
> -	.atomic_reset			= drm_atomic_helper_bridge_reset,
> +	.atomic_create_state			= drm_atomic_helper_bridge_create_state,

[Severity: Low]
Does this migration also need to update tidss_oldi_bridge_funcs in
drivers/gpu/drm/tidss/tidss_oldi.c? 

Looking at the driver, it appears that struct still uses the deprecated
atomic_reset callback:

drivers/gpu/drm/tidss/tidss_oldi.c:tidss_oldi_bridge_funcs {
        ...
        .atomic_reset = drm_atomic_helper_bridge_reset,
        ...
}

Should this be updated to atomic_create_state as well to completely remove
dependencies on the deprecated API from the tidss driver?

>  	.atomic_duplicate_state		= drm_atomic_helper_bridge_duplicate_state,
>  	.atomic_destroy_state		= drm_atomic_helper_bridge_destroy_state,
>  };

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=69