Re: [PATCH v4 2/4] drm/edid: parse HDMI 2.1 gaming (ALLM/VRR) capabilities from HF-VSDB

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Kerneldoc comments for `struct drm_hdmi_vrr_cap` refer to non-existent fields `@mcnmvrr` and `@mcinema_vrr` instead of `cnmvrr` and `cinema_vrr`, and contain minor typos.
--

--- Patch [2]: [PATCH v4 2/4] drm/edid: parse HDMI 2.1 gaming (ALLM/VRR) capabilities from HF-VSDB ---
commit c7bd732acb69a8a5eeca4f1e80e71d88085a1ae5
Author: Tomasz Pakuła <[email protected]>

drm/edid: parse HDMI 2.1 gaming (ALLM/VRR) capabilities from HF-VSDB

This commit parses the HDMI 2.1 gaming-related capabilities from the HDMI
Forum VSDB (HF-VSDB). It exposes them through struct drm_hdmi_info and
adds a new struct drm_hdmi_vrr_cap to describe VRR capabilities.

> diff --git a/include/drm/drm_connector.h b/include/drm/drm_connector.h
> index cd06a3b914a03..9f8f109c2dd1f 100644
> --- a/include/drm/drm_connector.h
> +++ b/include/drm/drm_connector.h
> @@ -254,6 +254,44 @@ struct drm_scdc {
>  	struct drm_scrambling scrambling;
>  };
>  
> +/**
> + * struct drm_hdmi_vrr_cap - Information about VRR capabilities of a HDMI sink
> + *
> + * Describes the VRR support provided by HDMI 2.1 sink. The information is
> + * fetched fom additional HFVSDB blocks defined for HDMI 2.1.

[Severity: Low]
This isn't a bug, but there is a typo here ("fom" instead of "from").

> + */
> +struct drm_hdmi_vrr_cap {
> +	/** @fva: flag for Fast VActive (Quick Frame Transport) support */
> +	bool fva;
> +
> +	/** @mcnmvrr: flag for Negative M VRR support */
> +	bool cnmvrr;

[Severity: Low]
This isn't a bug, but does this kerneldoc mismatch the field name? 
The documentation uses @mcnmvrr while the field is named cnmvrr.

> +
> +	/** @mcinema_vrr: flag for Cinema VRR support */
> +	bool cinema_vrr;

[Severity: Low]
This isn't a bug, but similarly here, the kerneldoc uses @mcinema_vrr 
instead of cinema_vrr.

> +
> +	/** @mdelta: flag for limited frame-to-frame compensation support */
> +	bool mdelta;
> +
> +	/**
> +	 * @vrr_min : minimum supported variable refresh rate in Hz.
> +	 * Valid values only inide 1 - 48 range

[Severity: Low]
This isn't a bug, but there is a typo here ("inide" instead of "inside").

> +	 */
> +	u16 vrr_min;

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=2