Re: [PATCH 2/4] dt-bindings: display: bcm2835-v3d: Add an optional reset line
Stefan Wahren <[email protected]>
| Newsgroups | org.freedesktop.lists.dri-devel,org.infradead.lists.linux-arm-kernel,org.kernel.vger.linux-devicetree |
|---|---|
| Message-ID | <[email protected]> |
Hi Maíra,
Am 16.08.26 um 16:05 schrieb Maíra Canal:
> The BCM2835 PM block has exposed a reset line for the V3D block since
> commit 670c672608a1 ("soc: bcm: bcm2835-pm: Add support for power domains
> under a new binding."), which allows the GPU to be reset without
> power-cycling its domain. Document it so that the vc4 driver can use it to
> recover from a GPU hang.
not sure the last sentence is necessary for a DT binding. Except of this:
Reviewed-by: Stefan Wahren <[email protected]>
>
> Keep the property optional, as existing device trees do not describe it.
>
> Signed-off-by: Maíra Canal <[email protected]>
> ---
> Documentation/devicetree/bindings/display/brcm,bcm2835-v3d.yaml | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/display/brcm,bcm2835-v3d.yaml b/Documentation/devicetree/bindings/display/brcm,bcm2835-v3d.yaml
> index c55a8217de25..1063e686647c 100644
> --- a/Documentation/devicetree/bindings/display/brcm,bcm2835-v3d.yaml
> +++ b/Documentation/devicetree/bindings/display/brcm,bcm2835-v3d.yaml
> @@ -27,6 +27,9 @@ properties:
> power-domains:
> maxItems: 1
>
> + resets:
> + maxItems: 1
> +
> required:
> - compatible
> - reg
>