Re: [PATCH 07/70] drm/gud: Switch to drm_atomic_helper_crtc_create_state

Ruben Wauters <[email protected]> Sun, 23 Aug 2026 17:36:52 +0100

Newsgroups	org.freedesktop.lists.dri-devel
Message-ID	<[email protected]>

On Fri, 2026-08-21 at 16:38 +0200, Maxime Ripard wrote:
> The gud crtc implementation uses the deprecated
> drm_atomic_helper_crtc_reset() as its reset hook.
> 
> Switch to drm_atomic_helper_crtc_create_state() instead.
> 
> Signed-off-by: Maxime Ripard <[email protected]>
Acked-by: Ruben Wauters <[email protected]>
> ---
> Cc: Ruben Wauters <[email protected]>
> ---
>  drivers/gpu/drm/gud/gud_drv.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/gud/gud_drv.c b/drivers/gpu/drm/gud/gud_drv.c
> index 89bd6ca36003..83a036c6e41d 100644
> --- a/drivers/gpu/drm/gud/gud_drv.c
> +++ b/drivers/gpu/drm/gud/gud_drv.c
> @@ -343,11 +343,11 @@ static const struct drm_crtc_helper_funcs gud_crtc_helper_funcs = {
>  	.atomic_enable = gud_crtc_atomic_enable,
>  	.atomic_disable = gud_crtc_atomic_disable,
>  };
>  
>  static const struct drm_crtc_funcs gud_crtc_funcs = {
> -	.reset = drm_atomic_helper_crtc_reset,
> +	.atomic_create_state = drm_atomic_helper_crtc_create_state,
>  	.destroy = drm_crtc_cleanup,
>  	.set_config = drm_atomic_helper_set_config,
>  	.page_flip = drm_atomic_helper_page_flip,
>  	.atomic_duplicate_state = drm_atomic_helper_crtc_duplicate_state,
>  	.atomic_destroy_state = drm_atomic_helper_crtc_destroy_state,

signature.asc (application/pgp-signature, 870 B)