Re: [PATCH v6 5/9] drm/panthor: Get rid of panthor_group::fatal_lock

Boris Brezillon <[email protected]>
Newsgroups org.freedesktop.lists.dri-devel,org.kernel.vger.linux-kernel
Organization Collabora
Message-ID <[email protected]>
On Mon, 17 Aug 2026 16:12:22 +0100
Steven Price <[email protected]> wrote:

> On 11/08/2026 12:23, Boris Brezillon wrote:
> > This lock is never used, and we're about to make fatal_queues an
> > atomic to cope with concurrent updates.
> > 
> > Signed-off-by: Boris Brezillon <[email protected]>  
> 
> Reviewed-by: Steven Price <[email protected]>
> 
> Although it does make me wonder if there's a fix that needs backporting...

I've audited all places where this field is accessed, and I think we're
covered by the panthor_scheduler::lock. The only place where this is
not the case is group_term_post_processing(), and I believe the
fatal_queues value is frozen at this point (can't be updated by IRQ
logic because the group has left its CSG slot).
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.