Re: [PATCH 15/70] drm/logicvc: Switch to drm_atomic_helper_crtc_create_state

Paul Kocialkowski <[email protected]> Mon, 24 Aug 2026 13:39:49 +0200

Newsgroups	org.freedesktop.lists.dri-devel
Message-ID	<aowthb5VAeG4JSEi@shepard>

Hi Maxime,

On Fri 21 Aug 26, 16:38, Maxime Ripard wrote:
> The logicvc crtc implementation uses the deprecated
> drm_atomic_helper_crtc_reset() as its reset hook.
> 
> Switch to drm_atomic_helper_crtc_create_state() instead.
> 
> Signed-off-by: Maxime Ripard <[email protected]>
> ---
> Cc: Paul Kocialkowski <[email protected]>
> ---
>  drivers/gpu/drm/logicvc/logicvc_crtc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/logicvc/logicvc_crtc.c b/drivers/gpu/drm/logicvc/logicvc_crtc.c
> index 81e5b80736fa..3fcebd6af6f4 100644
> --- a/drivers/gpu/drm/logicvc/logicvc_crtc.c
> +++ b/drivers/gpu/drm/logicvc/logicvc_crtc.c
> @@ -211,11 +211,11 @@ static void logicvc_crtc_disable_vblank(struct drm_crtc *drm_crtc)
>  	regmap_write_bits(logicvc->regmap, LOGICVC_INT_MASK_REG,
>  			  LOGICVC_INT_MASK_V_SYNC, LOGICVC_INT_MASK_V_SYNC);
>  }
>  
>  static const struct drm_crtc_funcs logicvc_crtc_funcs = {
> -	.reset			= drm_atomic_helper_crtc_reset,
> +	.atomic_create_state = drm_atomic_helper_crtc_create_state,

It looks like you are breaking the tab indent and replacing it with a single
space here. Could you keep the tab alignment instead?

Thanks,

Paul

>  	.destroy		= drm_crtc_cleanup,
>  	.set_config		= drm_atomic_helper_set_config,
>  	.page_flip		= drm_atomic_helper_page_flip,
>  	.atomic_duplicate_state	= drm_atomic_helper_crtc_duplicate_state,
>  	.atomic_destroy_state	= drm_atomic_helper_crtc_destroy_state,
> 
> -- 
> 2.55.0
> 

-- 
Paul Kocialkowski,

Independent contractor - sys-base - https://www.sys-base.io/
Free software developer - https://www.paulk.fr/

Expert in multimedia, graphics and embedded hardware support with Linux.

signature.asc (application/pgp-signature, 833 B)