Re: [PATCH v3 1/2] dt-bindings: display: Add GlandaGPU binding

[email protected]
Newsgroups org.freedesktop.lists.dri-devel,org.kernel.vger.linux-devicetree
Message-ID <[email protected]>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The new vendor prefix '^kieweg,.*' is inserted out of alphabetical order in vendor-prefixes.yaml.
--

--- Patch [1]: [PATCH v3 1/2] dt-bindings: display: Add GlandaGPU binding ---
commit 987b0ae0b2509987f3bf6af799a254628d7f7d34
Author: Leander Kieweg <[email protected]>

dt-bindings: display: Add GlandaGPU binding

This commit adds the Device Tree binding documentation for GlandaGPU, a
custom FPGA-based 2D display controller. It also adds a new vendor prefix
for the author in vendor-prefixes.yaml.

> diff --git a/Documentation/devicetree/bindings/vendor-prefixes.yaml b/Documentation/devicetree/bindings/vendor-prefixes.yaml
> index 1e54877628c75..e20d045980ac9 100644
> --- a/Documentation/devicetree/bindings/vendor-prefixes.yaml
> +++ b/Documentation/devicetree/bindings/vendor-prefixes.yaml

[ ... ]

> @@ -668,6 +668,8 @@ patternProperties:
>      description: Giantplus Technology Co., Ltd.
>    "^gira,.*":
>      description: Gira Giersiepen GmbH & Co. KG
> +  "^kieweg,.*":
> +    description: Leander Kieweg

[Severity: Low]
This isn't a bug, but it looks like the new vendor prefix was inserted out of
alphabetical order, landing in the middle of the "g" entries. Should this be
moved down to the "k" section to keep the list ordered and avoid future merge
conflicts?

>    "^glinet,.*":
>      description: GL Intelligence, Inc.
>    "^globalscale,.*":

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=1
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.